fix: fix problem with observe responses without observe option #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2214006857
💛 - Coveralls |
JKRhb
force-pushed
the
observe-initialization
branch
from
6f2a541 to
200afa4
Compare
JKRhb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I think I finally found the fix for iobroker-community-adapters/ioBroker.philips-air#15: As it turned out, a type check that I had introduced to make sure that only numeric Observe values are passed to the initialization of
ObserveStreamobjects caused them to not be initialized at all.This PR fixes the issue and illustrates that observing now finally works again with an example using the Eclipse Californium test server.