Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): correctly handle false observe values #346

Merged
merged 1 commit into from
May 19, 2022

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented May 18, 2022

This is a fix for coapjs/coap-cli#136. The case where the observe parameter is set to false has not been handled correctly, yet, causing clients to hang after a request has been finished.

@JKRhb JKRhb requested a review from Apollon77 May 18, 2022 22:03
@coveralls
Copy link

coveralls commented May 18, 2022

Pull Request Test Coverage Report for Build 2348435791

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 91.35%

Files with Coverage Reduction New Missed Lines %
lib/server.ts 2 86.94%
Totals Coverage Status
Change from base Build 2343713153: -0.4%
Covered Lines: 2840
Relevant Lines: 3053

💛 - Coveralls

@Apollon77 Apollon77 merged commit 23b2008 into coapjs:master May 19, 2022
@JKRhb JKRhb deleted the another-observe-fix branch May 20, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants