Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with bl types, reactivate tests #357

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Nov 23, 2022

This PR is a subset of #356, including the most important fix for @types/bl and reactivating the inactive tests. I'll rebase #356 once this one is merged – I had some problems getting the updated dependencies to work on Node 14 for some reason :/

@JKRhb JKRhb requested a review from Apollon77 November 23, 2022 21:48
@coveralls
Copy link

coveralls commented Nov 23, 2022

Pull Request Test Coverage Report for Build 3535908688

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+30.8%) to 91.83%

Totals Coverage Status
Change from base Build 3345980936: 30.8%
Covered Lines: 2848
Relevant Lines: 3059

💛 - Coveralls

@JKRhb JKRhb merged commit f812c56 into coapjs:master Nov 24, 2022
@JKRhb JKRhb deleted the bl-types branch November 25, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants