chore: upgrade dependencies to their latest versions #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
upgrade-dependencies
branch
2 times, most recently
from
c56d991 to
1fa01c5
Compare
JKRhb
force-pushed
the
upgrade-dependencies
branch
from
1fa01c5 to
43f42f5
Compare
Pull Request Test Coverage Report for Build 6946023196
💛 - Coveralls |
Pull Request Test Coverage Report for Build 6946023196
💛 - Coveralls |
Apollon77
reviewed
Nov 21, 2023
Pull Request Test Coverage Report for Build 6980298525
💛 - Coveralls |
Apollon77
approved these changes
Nov 24, 2023
|
Approved, merge wehen you are ready |
Awesome, thank you :) |
JKRhb
force-pushed
the
upgrade-dependencies
branch
from
36e26c5 to
1ac348a
Compare
edrose
added a commit
to edrose/node-coap
that referenced
this pull request
Dec 16, 2023
Fix for blockwise transfer issues raised in coapjs#373 where a coap message could avoid being split into blocks, yet still be larger than the allowable size of 1280 bytes. This applies the recommended maximum payload size from RFC 7252 Section 4.6 of 1024 bytes, and allows it to be reduced in the config parameters as required. The 'IP_MTU' constant has been renamed to 'MAX_PAYLOAD' to more accurately describe what the it represents. The 'maxPacketSize' parameter has also been renamed to 'maxPayload' size for the same reason. Note that the renaming of the parameter is a potentially breaking change.
edrose
added a commit
to edrose/node-coap
that referenced
this pull request
Dec 16, 2023
Fix for blockwise transfer issues raised in coapjs#373 where a coap message could avoid being split into blocks, yet still be larger than the allowable size of 1280 bytes. This applies the recommended maximum payload size from RFC 7252 Section 4.6 of 1024 bytes, and allows it to be reduced in the config parameters as required. The error that this fixes was introduced in d727d43 and this attempts to keep the intent behind that commit, whilst fixing the technical flaws that it introduced. The 'IP_MTU' constant has been renamed to 'MAX_PAYLOAD' to more accurately describe what the it represents. The 'maxPacketSize' parameter has also been renamed to 'maxPayloadSize' for the same reason. Note that the renaming of the parameter is a potentially breaking change.
edrose
added a commit
to edrose/node-coap
that referenced
this pull request
Dec 17, 2023
Fix for blockwise transfer issues raised in coapjs#373 where a coap message could avoid being split into blocks, yet still be larger than the allowable size of 1280 bytes. This applies the recommended maximum payload size from RFC 7252 Section 4.6 of 1024 bytes, and allows it to be reduced in the config parameters as required. The error that this fixes was introduced in d727d43 and this attempts to keep the intent behind that commit, whilst fixing the technical flaws that it introduced. The 'IP_MTU' constant has been renamed to 'MAX_PAYLOAD' to more accurately describe what the it represents. The 'maxPacketSize' parameter has also been renamed to 'maxPayloadSize' for the same reason. Note that the renaming of the parameter is a potentially breaking change.
edrose
added a commit
to edrose/node-coap
that referenced
this pull request
Dec 17, 2023
Fix for blockwise transfer issues raised in coapjs#373 where a coap message could avoid being split into blocks, yet still be larger than the allowable size of 1280 bytes. This applies the recommended maximum payload size from RFC 7252 Section 4.6 of 1024 bytes, and allows it to be reduced in the config parameters as required. The error that this fixes was introduced in d727d43 and this attempts to keep the intent behind that commit, whilst fixing the technical flaws that it introduced. The 'IP_MTU' constant has been renamed to 'MAX_PAYLOAD' to more accurately describe what the it represents. The 'maxPacketSize' parameter has also been renamed to 'maxPayloadSize' for the same reason. Note that the renaming of the parameter is a potentially breaking change.
edrose
added a commit
to edrose/node-coap
that referenced
this pull request
Dec 17, 2023
Fix for blockwise transfer issues raised in coapjs#373 where a coap message could avoid being split into blocks, yet still be larger than the allowable size of 1280 bytes. This applies the recommended maximum payload size from RFC 7252 Section 4.6 of 1024 bytes, and allows it to be reduced in the config parameters as required. The error that this fixes was introduced in d727d43 and this attempts to keep the intent behind that commit, whilst fixing the technical flaws that it introduced. The 'IP_MTU' constant has been renamed to 'MAX_PAYLOAD' to more accurately describe what the it represents. The 'maxPacketSize' parameter has also been renamed to 'maxPayloadSize' for the same reason. Note that the renaming of the parameter is a potentially breaking change.
Apollon77
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Update blockwise tests to catch edge-cases Updates the blockwise tests to catch the cases where the payload is smaller than 'maxPacket', but the overall packet size after the headers are added exceeds 'maxPacket' which causes an error to be thrown. Also adds checks to ensure that the response code is 2.05 for the tests that require it, so 5.00 errors can't sneak through. * Update automatic blockwise transfer logic Fix for blockwise transfer issues raised in #373 where a coap message could avoid being split into blocks, yet still be larger than the allowable size of 1280 bytes. This applies the recommended maximum payload size from RFC 7252 Section 4.6 of 1024 bytes, and allows it to be reduced in the config parameters as required. The error that this fixes was introduced in d727d43 and this attempts to keep the intent behind that commit, whilst fixing the technical flaws that it introduced. The 'IP_MTU' constant has been renamed to 'MAX_PAYLOAD' to more accurately describe what the it represents. The 'maxPacketSize' parameter has also been renamed to 'maxPayloadSize' for the same reason. Note that the renaming of the parameter is a potentially breaking change. * Perform extra checks on CoAP message size This fixes the logic for checking the maximum CoAP message size. The check is actually performed in the coap-packet repository in a default parameter on the `generate()` function, however the default value is not appropriate for all (if any) cases. The maximum size that a CoAP message can be is the IP MTU, minus the IP header and minus the UDP header. The value is not constant across all IP network stacks, so the CoAP specification recommends a maximum of 1152 bytes for cases where it is not known. The only way to know for sure is MTU path discovery, which is way outside of the scope of the project. This commit creates a parameter that allows the max packet size to be adjusted as a server parameter for cases where (for example) the server is running on a 6LoWPAN/Thread network and needs a lower maximum message size. Note that the logic for enforcing the size is just to throw an error and crash the server. However, since the maximum payload size is enforced a situation like that should never occur.
JimmyBjorklund
pushed a commit
to JimmyBjorklund/node-coap
that referenced
this pull request
May 28, 2024
* Update blockwise tests to catch edge-cases Updates the blockwise tests to catch the cases where the payload is smaller than 'maxPacket', but the overall packet size after the headers are added exceeds 'maxPacket' which causes an error to be thrown. Also adds checks to ensure that the response code is 2.05 for the tests that require it, so 5.00 errors can't sneak through. * Update automatic blockwise transfer logic Fix for blockwise transfer issues raised in coapjs#373 where a coap message could avoid being split into blocks, yet still be larger than the allowable size of 1280 bytes. This applies the recommended maximum payload size from RFC 7252 Section 4.6 of 1024 bytes, and allows it to be reduced in the config parameters as required. The error that this fixes was introduced in d727d43 and this attempts to keep the intent behind that commit, whilst fixing the technical flaws that it introduced. The 'IP_MTU' constant has been renamed to 'MAX_PAYLOAD' to more accurately describe what the it represents. The 'maxPacketSize' parameter has also been renamed to 'maxPayloadSize' for the same reason. Note that the renaming of the parameter is a potentially breaking change. * Perform extra checks on CoAP message size This fixes the logic for checking the maximum CoAP message size. The check is actually performed in the coap-packet repository in a default parameter on the `generate()` function, however the default value is not appropriate for all (if any) cases. The maximum size that a CoAP message can be is the IP MTU, minus the IP header and minus the UDP header. The value is not constant across all IP network stacks, so the CoAP specification recommends a maximum of 1152 bytes for cases where it is not known. The only way to know for sure is MTU path discovery, which is way outside of the scope of the project. This commit creates a parameter that allows the max packet size to be adjusted as a server parameter for cases where (for example) the server is running on a 6LoWPAN/Thread network and needs a lower maximum message size. Note that the logic for enforcing the size is just to throw an error and crash the server. However, since the maximum payload size is enforced a situation like that should never occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all dependencies except
readable-streamandsinon. Especially the latter one needs some more special treatment to keep working.