Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a User I want to add basic styles (bold, italic...) to the document using toolbar #20

Closed
16 of 17 tasks
kalitine opened this issue Oct 24, 2016 · 1 comment
Closed
16 of 17 tasks
Assignees
Labels

Comments

@kalitine
Copy link
Collaborator

kalitine commented Oct 24, 2016

Toolbar

It is created via Angular Material Button Toggle

Toolbar buttons (ticked if functionnal)

  • bold
  • italic
  • strikethrough
  • link (url focused in any case)
  • quote (force the syntax to appear at beginning of lines)
  • headers (force the syntax to appear at beginning of lines)
  • lists (force the syntax to appear at beginning of lines)

About toggling

  • buttons must be toggled when the related style is detected

Behaviour

Appearence

  • on a double click that creates a selection for the editor
  • on a mouse-clicked-creating a selection
  • on a Shift+Arrow-creating a selection

Disappearence

  • on a click on the editor
  • on blur
  • when the selection disappear (by moving the cursor thanks to arrows for example)
  • when the selection is removed (by a suppression for example)

Display

Limits

  • Can't use both shortcuts and toggle buttons without desynchronizing toggle buttons highlights. It seems to be related to Angular Material.
  • Double click selections cover __text__ but not **text** (example), so the use of the toolbar in these cases is a bit limited
@kalitine kalitine added this to the Version 2 milestone Oct 24, 2016
@oster oster added the intern_2 label Apr 7, 2017
@kalitine kalitine modified the milestones: Rich Text Editor, Version 2 Jun 14, 2017
@menou2u
Copy link
Contributor

menou2u commented Jun 21, 2017

A way to achieve this task : http://codemirror.net/doc/manual.html#keymaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants