-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent & entanglement rust implementation #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to block this PR only because of the env var thing, but if we have more changes then that should be improved as well.
But the main change request I have is, not having a good portion of added lines be the same
let agent_instance = AgentService::instance();
let agent_service = agent_instance.lock().expect("agent lock");
let agent_ref: &AgentService = agent_service.as_ref().expect("agent instance");
over and over again. Adding something like Ad4mDb::with_global_instance() to AgentService
(or all our singletons) will reduce noice and deadlock risk.
…nstance to improve code readabiliy
No description provided.