Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent & entanglement rust implementation #469

Merged
merged 32 commits into from
Apr 9, 2024
Merged

Conversation

fayeed
Copy link
Member

@fayeed fayeed commented Mar 7, 2024

No description provided.

@fayeed fayeed changed the title Agent entanglement rust Agent & entanglement rust implementation Mar 7, 2024
@fayeed fayeed marked this pull request as ready for review April 1, 2024 05:52
@fayeed fayeed requested a review from lucksus April 1, 2024 08:17
Copy link
Member

@lucksus lucksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to block this PR only because of the env var thing, but if we have more changes then that should be improved as well.

But the main change request I have is, not having a good portion of added lines be the same

let agent_instance = AgentService::instance();
let agent_service = agent_instance.lock().expect("agent lock");
let agent_ref: &AgentService = agent_service.as_ref().expect("agent instance");

over and over again. Adding something like Ad4mDb::with_global_instance() to AgentService (or all our singletons) will reduce noice and deadlock risk.

executor/src/core/agent/AgentService.ts Show resolved Hide resolved
rust-executor/src/agent/mod.rs Outdated Show resolved Hide resolved
rust-executor/src/entanglement_service/mod.rs Outdated Show resolved Hide resolved
rust-executor/src/graphql/mutation_resolvers.rs Outdated Show resolved Hide resolved
@fayeed fayeed requested a review from lucksus April 8, 2024 07:30
@lucksus lucksus merged commit cb56887 into dev Apr 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants