Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fmt and clippy #513

Merged
merged 30 commits into from
Aug 9, 2024
Merged

Fmt and clippy #513

merged 30 commits into from
Aug 9, 2024

Conversation

lucksus
Copy link
Member

@lucksus lucksus commented Aug 8, 2024 •
edited
Loading

  • Clean up code to have cargo fmt --check and cargo clippy be happy with it.
  • Added those checks to CI so PRs will be red if they are not clean
  • added a git pre-push hook that can be installed by running setup-hooks.sh in the root dir to get feedback automatically before every push

@lucksus lucksus marked this pull request as ready for review August 8, 2024 16:19
@lucksus lucksus requested a review from fayeed August 8, 2024 16:20
@lucksus lucksus merged commit 5930db5 into dev Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fayeed fayeed fayeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucksus @fayeed