Secret generator #11
Open
Secret generator #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrestF
reviewed
Nov 14, 2022
|
|
||
| module RCreds | ||
| module Generators | ||
| class SecretGenerator < Rails::Generators::Base |
OrestF
reviewed
Nov 14, 2022
| class SecretGenerator < Rails::Generators::Base | ||
| desc 'Generates quantum computed secret.' | ||
|
|
||
| URI('https://qrng.anu.edu.au/API/jsonI.php').then do |uri| |
There was a problem hiding this comment.
what if no internet connection?
dmrAnderson
force-pushed
the
secret_generator
branch
from
bdc41eb to
42f6a86
Compare
OrestF
reviewed
Nov 14, 2022
| uri.query = URI.encode_www_form({ length: 1, type: 'hex16', size: 64 }) | ||
|
|
||
| Net::HTTP.get_response(uri).then do |response| | ||
| case response |
There was a problem hiding this comment.
change to if else if only 2 options
OrestF
approved these changes
Nov 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.