Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having full page contents in RSS feeds is not possible #724

Closed
rotty opened this issue Feb 11, 2020 · 0 comments · Fixed by #725
Closed

Having full page contents in RSS feeds is not possible #724

rotty opened this issue Feb 11, 2020 · 0 comments · Fixed by #725

Comments

@rotty
Copy link
Contributor

rotty commented Feb 11, 2020

As described in this comment on #309, and confirmed by @epage in a reply, setting excerpt_separator to the empty string is intended to cause the full page contents appear in the RSS feed, but it currently leads to the feed's item contents being empty.
rotty added a commit to rotty/cobalt.rs that referenced this issue Feb 11, 2020
@rotty
Do not populate attributes with Nil excerpt
62579c1 
Setting `excerpt_separator` to the empty string is intended to disable
auto-extracted excerpts, and, as a side-effect, cause the full content
to be used in the RSS feed.

Before this change, this did not happen, as
`Document::description_to_str` would render the `Nil` value inserted
into the "excerpt" attribute in all cases.

Fixes cobalt-org#724.
@rotty rotty mentioned this issue Feb 11, 2020
Merged
rotty added a commit to rotty/cobalt.rs that referenced this issue Feb 12, 2020
@rotty
fix: Do not render Nil excerpt
5bd996d 
Setting `excerpt_separator` to the empty string is intended to disable
auto-extracted excerpts, and, as a side-effect, cause the full content
to be used in the RSS feed.

Before this change, this did not happen, as
`Document::description_to_str` would render the `Nil` value inserted
into the "excerpt" attribute. We now avoid rendering a `Nil` excerpt,
and fall back to rendering the full content instead.

Fixes cobalt-org#724.
rotty added a commit to rotty/cobalt.rs that referenced this issue Feb 12, 2020
@rotty
fix: Do not render Nil excerpt
94b4c18 
Setting `excerpt_separator` to the empty string is intended to disable
auto-extracted excerpts, and, as a side-effect, cause the full content
to be used in the RSS feed.

Before this change, this did not happen, as
`Document::description_to_str` would render the `Nil` value inserted
into the "excerpt" attribute. We now avoid rendering a `Nil` excerpt,
and fall back to rendering the full content instead.

Fixes cobalt-org#724.
rotty added a commit to rotty/cobalt.rs that referenced this issue Feb 12, 2020
@rotty
fix: Do not render Nil excerpt
bf39bf9 
Setting `excerpt_separator` to the empty string is intended to disable
auto-extracted excerpts, and, as a side-effect, cause the full content
to be used in the RSS feed.

Before this change, this did not happen, as
`Document::description_to_str` would render the `Nil` value inserted
into the "excerpt" attribute. We now avoid rendering a `Nil` excerpt,
and fall back to rendering the full content instead.

Fixes: cobalt-org#724
epage pushed a commit to epage/cobalt.rs that referenced this issue Feb 13, 2020
@rotty
fix: Do not render Nil excerpt
9313272 
Setting `excerpt_separator` to the empty string is intended to disable
auto-extracted excerpts, and, as a side-effect, cause the full content
to be used in the RSS feed.

Before this change, this did not happen, as
`Document::description_to_str` would render the `Nil` value inserted
into the "excerpt" attribute. We now avoid rendering a `Nil` excerpt,
and fall back to rendering the full content instead.

Fixes: cobalt-org#724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Do not render Nil excerpt rotty/cobalt.rs
1 participant
@rotty