Expose more fields in OperatingSystemStatus

[toanju]

Expose more fields in OperatingSystemStatus

Exposes the following additional fields

• GardenLinuxCommitID
• GardenLinuxFeatures
• VariantID

to share more details on a Garden Linux based installation

[fwiesel]

I see the need in it, and it is probably just bike-shedding, but this is tied to the gardenlinux build process, and doesn't cover all the inputs (i.e. GARDENLINUX_CNAME).

How about setting and using some standard fields instead?
I'd be a fan of setting BUILD_ID to ${{github.workflow}}-${{github.run_number}} or ${{github.run_id}}.

Or would VARIANT_ID and GARDENLINUX_COMMIT_ID suffice to uniquely identify the build?

[fwiesel]

I'll approve it, in case you want to move forward regardless of the alternatives proposed.
Worst-case we migrate..

[fwiesel]

Small detail, I'd go a least with commitID or even gardenlinuxCommitID as that is the name in the os-release file.

[toanju]

we were discussing if BUILD_ID actually suites here, however BUILD_ID does not really match for Garden Linux since we do not have a particular underlying build that resides the same. Will update to commitID.

[toanju]

I agree with

would VARIANT_ID and GARDENLINUX_COMMIT_ID suffice to uniquely identify the build

and adjusted accordingly and added the Features in addition

[anokfireball]

Maybe it is worth it to "properly" expose the feature list? Don't feel forced to follow through with this suggestion, though!

[toanju]

yes, I was thinking about the list, but still checking on the guarantees here

[toanju]

list it is...

[github-actions]

Merging this branch will not change overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1	0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1	0.00% (ø)

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go	0.00% (ø)	0	0	0
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/zz_generated.deepcopy.go	0.00% (ø)	0	0	0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/operatingsystemstatus.go	0.00% (ø)	0	0	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.