Refactor conditions, introduce terminating maintenance#202
Merged
Conversation
notandy
force-pushed
the
refactor-conditions
branch
from
74434e9 to
e65e4eb
Compare
Consolidate all condition to their respective API spec, this makes it easier and clearer for external componenets to identify condition and reason, also reuse conditions that are similar (Complated -> Successful). Also introducing a new maintenance enum value "terminating", that is set by the maintenance-operator in case the node is terminating - removing the need to monitor nodes status.
notandy
force-pushed
the
refactor-conditions
branch
from
e65e4eb to
8539456
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
fwiesel
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate all condition to their respective API spec, this makes it
easier and clearer for external components to identify condition and
reason, also reuse conditions that are similar (Completed ->
Successful). Also fixes CamelCase requirement for conditionReasons.
Also introducing a new maintenance enum value "terminating", that is
set by the maintenance-operator in case the node is terminating -
removing the need to monitor nodes status.