Offboarding hypervisor #209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwiesel
force-pushed
the
offboarding-hypervisor
branch
from
3c8c43f to
dd8e041
Compare
Contributor
|
We had the discussion about finalizers on the hypervisor object, I won't waste time about it again, sry. |
The tests before where partly relying one a global context, which means the cancelation from ginkgo wasn't really passed down. The leaf functions can take a context.Context or SpecContext argument. The latter is already imported, so lets go with that one.
fwiesel
force-pushed
the
offboarding-hypervisor
branch
from
dd8e041 to
f39b475
Compare
fwiesel
force-pushed
the
offboarding-hypervisor
branch
from
f39b475 to
9bb91b2
Compare
This also needs some manual migration work: The finalizer in the node needs to get manually removed, and the name change of the controller-name requires a reset of the field owners.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Contributor
Author
|
I think, I know how do it without finalizers... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.