moved desired_capabilities inside if statement to add compatibility … #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with new versions of selenium
|
IMO this is good. It fixes #1173 which would be really good to resolve. Anyone able to review and merge this? |
fsouza
reviewed
Nov 1, 2023
fsouza
approved these changes
Nov 4, 2023
|
@fsouza if it's possible to get a new release of splinter with this patch in it, that'd be amazing |
|
Sounds good, I'll prep that release later this week if no one beats me to it cc @jsfehler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this commit here SeleniumHQ/selenium@9f5801c#diff-89ba579445647535b74423c7bf4b8be79ef1ce33847a2768e623c3083a33545d
desired_capabilitieshas been removed from selenium 4.10.0 and up. This commits allows for old and new versions of selenium to work either using the neweroptionsargument or the olddesired_capabilities. This also prevents the error from seleniumTypeError: WebDriver.__init__() got an unexpected keyword argument 'desired_capabilities'It fixes issue #1173