Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mac support back #3

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Add mac support back #3

merged 3 commits into from
Apr 18, 2019

Conversation

TylerLeonhardt
Copy link
Collaborator

macOS doesn't support the shebang:

#!/usr/bin/env pwsh

so we explicitly say pwsh path/to/install.ps1

We assume they have pwsh on their path since that will be required anyway.

Also this makes the install script a tad less loud - Progress is not rendered well in vim.

yatli
yatli approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@yatli yatli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tyler!

@yatli yatli merged commit 3167b34 into coc-extensions:master Apr 18, 2019
@TylerLeonhardt TylerLeonhardt deleted the add-mac-support branch April 18, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatli yatli yatli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerLeonhardt @yatli