Move PSES log to PSES folder #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it depends on the use case. If you want to start multiple instances, the session files should be targeted at different paths. Nevertheless, keeping them in the plugin directory is a good idea. |
If User doesn't specify, use a directory that should be unique enough to not cause overlap of logs for users running multiple sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the PSES log and session file to the PSES folder within the Plugin as opposed to containing it within the working directory that vim was launched from.
It might be worth adding the PID and/or date to the path like we do with vscode-powershell to keep the logs separate between editing sessions.