Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection by using coc API #60

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Fix selection by using coc API #60

merged 2 commits into from
Jul 30, 2019

Conversation

TylerLeonhardt
Copy link
Collaborator

Fixes #57

and fixes one of @mikeTWC1984's concerns.

This will honor an inline selection.

if(!(Get-Command npm)) {

}

if I select JUST Get-Command npm in the above snippet, it will run ONLY Get-Command npm and not the full line.

@TylerLeonhardt TylerLeonhardt requested a review from yatli July 29, 2019 16:40
@TylerLeonhardt TylerLeonhardt mentioned this pull request Jul 29, 2019
Closed
@TylerLeonhardt
Copy link
Collaborator Author

@corbob you also mentioned this to me once so here's some good news!

@TylerLeonhardt
Copy link
Collaborator Author

Merging now after offline 👍 by @yatli

@TylerLeonhardt TylerLeonhardt merged commit bd4a4e7 into coc-extensions:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatli yatli Awaiting requested review from yatli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

powershell.evaluateSelection - executes entire line, not a selection
1 participant
@TylerLeonhardt