Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get powershell path in a better way #92

Conversation

TylerLeonhardt
Copy link
Collaborator

@TylerLeonhardt TylerLeonhardt commented Apr 16, 2020

This grabs the implementation from vscode-powershell which has a more fully featured way of discovering what PowerShell exe's are installed on the system.

This also supports the same setting as vscode-powershell:

"powershell.powerShellAdditionalExePaths": [
        {
            "exePath": "/Users/tyleonha/.powershell-daily/pwsh",
            "versionName": "PowerShell Daily"
        },
        {
            "exePath": "/Users/tyleonha/Code/PowerShell/PowerShell/src/powershell-unix/bin/Debug/netcoreapp3.1/osx-x64/publish/pwsh",
            "versionName": "PowerShell Local Build"
        }
],

"powershell.powerShellDefaultVersion": "PowerShell Daily"

I'd say you don't have to worry about reviewing src/client/platform.ts since that was already battle tested in vscode-powershell but review everything else :)

This also means coc-powershell will bring in PSES 2.1.0 which includes a ton of perf improvements and PSReadLine support in the integrated console.

@TylerLeonhardt TylerLeonhardt requested a review from yatli April 16, 2020 16:48
@TylerLeonhardt TylerLeonhardt merged commit 4ae1ea8 into coc-extensions:master Apr 16, 2020
@TylerLeonhardt TylerLeonhardt deleted the get-powershell-path-in-a-better-way branch April 16, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants