Get powershell path in a better way #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This grabs the implementation from
vscode-powershell
which has a more fully featured way of discovering what PowerShell exe's are installed on the system.This also supports the same setting as vscode-powershell:
I'd say you don't have to worry about reviewing
src/client/platform.ts
since that was already battle tested in vscode-powershell but review everything else :)This also means
coc-powershell
will bring in PSES 2.1.0 which includes a ton of perf improvements and PSReadLine support in the integrated console.