Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Adjust centos-9-bootc for cockpit testing #7365

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Jan 29, 2025

@cockpituous cockpituous changed the title images: Adjust centos-9-bootc for cockpit testing WIP: b7bf4a587775: [no-test] images: Adjust centos-9-bootc for cockpit testing Jan 29, 2025
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: b7bf4a587775: [no-test] images: Adjust centos-9-bootc for cockpit testing images: Adjust centos-9-bootc for cockpit testing Jan 29, 2025
@cockpituous
Copy link
Contributor

@martinpitt martinpitt force-pushed the c9bootc-cockpit-deps branch from 12b7588 to 29d7495 Compare January 29, 2025 06:16
@cockpituous cockpituous changed the title images: Adjust centos-9-bootc for cockpit testing WIP: 972b16aaeb65: [no-test] images: Adjust centos-9-bootc for cockpit testing Jan 29, 2025
@cockpituous cockpituous changed the title WIP: 972b16aaeb65: [no-test] images: Adjust centos-9-bootc for cockpit testing images: Adjust centos-9-bootc for cockpit testing Jan 29, 2025
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title images: Adjust centos-9-bootc for cockpit testing WIP: 00308169cb3a: [no-test] images: Adjust centos-9-bootc for cockpit testing Jan 29, 2025
@cockpituous cockpituous changed the title WIP: 00308169cb3a: [no-test] images: Adjust centos-9-bootc for cockpit testing images: Adjust centos-9-bootc for cockpit testing Jan 29, 2025
@cockpituous
Copy link
Contributor

@martinpitt martinpitt force-pushed the c9bootc-cockpit-deps branch from 29d7495 to e928515 Compare January 29, 2025 07:16
@martinpitt
Copy link
Member Author

OK, let's try without updating the kernel.

@cockpituous cockpituous changed the title images: Adjust centos-9-bootc for cockpit testing WIP: 9914e3ab4a9e: [no-test] images: Adjust centos-9-bootc for cockpit testing Jan 29, 2025
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 9914e3ab4a9e: [no-test] images: Adjust centos-9-bootc for cockpit testing images: Adjust centos-9-bootc for cockpit testing Jan 29, 2025
@cockpituous
Copy link
Contributor

martinpitt and others added 4 commits January 30, 2025 09:45
config.json cannot do that. Some tests expect this, so let's keep our
images uniform.
This gives us the latest packages, so that the image stays compatible
with the generated runtime dependencies from the rpm build (such as
selinux-policy).

However, exclude the kernel as that current causes kernel oopses.
This will allow us to install cockpit-ws.rpm and run networking and
metrics tests.

Also toss in strace as the ultimate debugging tool, and rsync for
`build.js -r` and a more efficient bots API.

See cockpit-project/cockpit#21561
@martinpitt martinpitt force-pushed the c9bootc-cockpit-deps branch from 3dc43fb to a434ce4 Compare January 30, 2025 08:45
@martinpitt martinpitt marked this pull request as ready for review January 30, 2025 08:46
@martinpitt martinpitt requested a review from jelly January 30, 2025 08:46
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

RUN \
dnf update -y --exclude='kernel*' && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a known issue, sounds like it could use a # HACK unless we never want to support it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's at least not necessary for us to support. I had to add it because the original container has a too old selinux-policy -- the rpm build in the mock of centos-9-stream depended on a newer version. I haven't reported the kernel failure yet, but added to my TODO list.

@martinpitt martinpitt merged commit be4f75c into cockpit-project:main Jan 30, 2025
7 checks passed
@martinpitt martinpitt deleted the c9bootc-cockpit-deps branch January 30, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants