Switch to biome from eslint #672
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| { | ||
| "$schema": "https://biomejs.dev/schemas/1.8.3/schema.json", | ||
| "organizeImports": { "enabled": true }, | ||
| "linter": { | ||
| "enabled": true, | ||
| "rules": { | ||
| "recommended": false, | ||
| "a11y": { | ||
| "noAccessKey": "error", | ||
| "noAriaUnsupportedElements": "error", | ||
| "noAutofocus": "error", | ||
| "noBlankTarget": "error", | ||
| "noDistractingElements": "error", | ||
| "noHeaderScope": "error", | ||
| "noInteractiveElementToNoninteractiveRole": "error", | ||
| "noNoninteractiveElementToInteractiveRole": "error", | ||
| "noNoninteractiveTabindex": "error", | ||
| "noPositiveTabindex": "error", | ||
| "noRedundantAlt": "error", | ||
| "noRedundantRoles": "error", | ||
| "useAltText": "error", | ||
| "useAnchorContent": "error", | ||
| "useAriaActivedescendantWithTabindex": "error", | ||
| "useAriaPropsForRole": "error", | ||
| "useHeadingContent": "error", | ||
| "useHtmlLang": "error", | ||
| "useIframeTitle": "error", | ||
| "useKeyWithClickEvents": "error", | ||
| "useKeyWithMouseEvents": "error", | ||
| "useMediaCaption": "error", | ||
| "useValidAnchor": "off", | ||
| "useValidAriaProps": "error", | ||
| "useValidAriaRole": "error", | ||
| "useValidAriaValues": "error" | ||
| }, | ||
| "complexity": { | ||
| "noExtraBooleanCast": "error", | ||
| "noMultipleSpacesInRegularExpressionLiterals": "error", | ||
| "noUselessCatch": "error", | ||
| "noUselessConstructor": "error", | ||
| "noUselessFragments": "error", | ||
| "noUselessLoneBlockStatements": "error", | ||
| "noUselessRename": "error", | ||
| "noUselessTernary": "error", | ||
| "noVoid": "error", | ||
| "noWith": "error", | ||
| "useLiteralKeys": "error", | ||
| "useRegexLiterals": "error" | ||
| }, | ||
| "correctness": { | ||
| "noChildrenProp": "error", | ||
| "noConstAssign": "error", | ||
| "noConstantCondition": "error", | ||
| "noEmptyCharacterClassInRegex": "error", | ||
| "noEmptyPattern": "error", | ||
| "noGlobalObjectCalls": "error", | ||
| "noInnerDeclarations": "error", | ||
| "noInvalidConstructorSuper": "error", | ||
| "noInvalidUseBeforeDeclaration": "error", | ||
| "noNewSymbol": "error", | ||
| "noNonoctalDecimalEscape": "error", | ||
| "noPrecisionLoss": "error", | ||
| "noSelfAssign": "error", | ||
| "noSetterReturn": "error", | ||
| "noSwitchDeclarations": "error", | ||
| "noUndeclaredVariables": "error", | ||
| "noUnreachable": "error", | ||
| "noUnreachableSuper": "error", | ||
| "noUnsafeFinally": "error", | ||
| "noUnsafeOptionalChaining": "error", | ||
| "noUnusedLabels": "error", | ||
| "noUnusedVariables": "error", | ||
| "useArrayLiterals": "error", | ||
| "useExhaustiveDependencies": "error", | ||
| "useHookAtTopLevel": "error", | ||
| "useIsNan": "error", | ||
| "useJsxKeyInIterable": "error", | ||
| "useValidForDirection": "error", | ||
| "useYield": "error" | ||
| }, | ||
| "security": { | ||
| "noDangerouslySetInnerHtmlWithChildren": "error", | ||
| "noGlobalEval": "error" | ||
| }, | ||
| "style": { | ||
| "noCommaOperator": "error", | ||
| "noImplicitBoolean": "error", | ||
| "noVar": "error", | ||
| "useBlockStatements": "off", | ||
| "useConst": "error", | ||
| "useFragmentSyntax": "error", | ||
| "useSingleVarDeclarator": "error" | ||
| }, | ||
| "suspicious": { | ||
| "noAssignInExpressions": "error", | ||
| "noAsyncPromiseExecutor": "error", | ||
| "noCatchAssign": "error", | ||
| "noClassAssign": "error", | ||
| "noCommentText": "error", | ||
| "noCompareNegZero": "error", | ||
| "noConfusingLabels": "error", | ||
| "noConsoleLog": "off", | ||
| "noControlCharactersInRegex": "error", | ||
| "noDebugger": "error", | ||
| "noDoubleEquals": "error", | ||
| "noDuplicateCase": "error", | ||
| "noDuplicateClassMembers": "error", | ||
| "noDuplicateJsxProps": "error", | ||
| "noDuplicateObjectKeys": "error", | ||
| "noDuplicateParameters": "error", | ||
| "noEmptyBlockStatements": "error", | ||
| "noFallthroughSwitchClause": "error", | ||
| "noFunctionAssign": "error", | ||
| "noGlobalAssign": "error", | ||
| "noImportAssign": "error", | ||
| "noMisleadingCharacterClass": "error", | ||
| "noPrototypeBuiltins": "error", | ||
| "noRedeclare": "error", | ||
| "noSelfCompare": "error", | ||
| "noShadowRestrictedNames": "error", | ||
| "noUnsafeNegation": "error", | ||
| "useDefaultSwitchClauseLast": "error", | ||
| "useGetterReturn": "error", | ||
| "useValidTypeof": "error" | ||
| } | ||
| }, | ||
| "ignore": ["node_modules/*", "pkg/lib/*", "bots/*"] | ||
|
There was a problem hiding this comment. pkg/lib contains shared component which should be linted I'd say but this was already in ignore. So leave it be, was more a surprise for me :) There was a problem hiding this comment. We can also enable git integration: {
"vcs": {
"enabled": true,
"clientKind": "git"
}
}That way we don't need to do any "ignore" in linter or formatter. There was a problem hiding this comment. node_modules are a submodule, wouldn't that be checked then? There was a problem hiding this comment. we would any ways. bots has a bunch of broken symlinks that cause biome to spit out internal fs errors There was a problem hiding this comment.
I believe Biome ignores node_modules even without git integration. It's for the other files/folders in that are ignored in git.
Interesting. I think /bots is already in |
||
| }, | ||
| "javascript": { | ||
| "globals": ["require", "module", "document", "navigator", "window"] | ||
|
There was a problem hiding this comment. Does biome not support setting the There was a problem hiding this comment. This is maybe something we should fix... There was a problem hiding this comment. I think this is unnecessary. There was a problem hiding this comment. this was imported from the eslint config |
||
| }, | ||
| "overrides": [{ "include": ["**/*.ts", "**/*.tsx"] }], | ||
|
There was a problem hiding this comment. this was also inherited from the eslint config |
||
| "formatter": { | ||
|
There was a problem hiding this comment. Please use spaces: {
"formatter": {
"indentStyle": "space"
}
}And possibly add |
||
| "ignore": ["node_modules/*", "pkg/lib/*", "bots/*"] | ||
|
There was a problem hiding this comment. We won't need this with the git integration. There was a problem hiding this comment. we would see my comment on bots |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,66 +1,58 @@ | ||
| { | ||
| "name": "files", | ||
| "description": "Scaffolding for a cockpit module", | ||
| "type": "module", | ||
| "main": "index.js", | ||
| "repository": "git@github.com:cockpit-project/cockpit-files.git", | ||
| "author": "", | ||
| "license": "LGPL-2.1", | ||
| "scripts": { | ||
| "watch": "./build.js -w", | ||
| "build": "./build.js", | ||
| "lint": "biome lint src/*", | ||
| "lint:fix": "biome lint src/* --fix", | ||
| "format": "biome format src/* --fix", | ||
| "stylelint": "stylelint src/*{.css,scss}", | ||
| "stylelint:fix": "stylelint --fix src/*{.css,scss}" | ||
| }, | ||
| "devDependencies": { | ||
| "@biomejs/biome": "1.8.3", | ||
| "@types/react": "18.3.3", | ||
| "@types/react-dom": "18.3.0", | ||
| "@typescript-eslint/eslint-plugin": "7.16.1", | ||
| "argparse": "2.0.1", | ||
| "chrome-remote-interface": "0.33.0", | ||
| "esbuild": "0.23.0", | ||
| "esbuild-plugin-copy": "2.1.1", | ||
| "esbuild-plugin-replace": "1.4.0", | ||
| "esbuild-sass-plugin": "3.3.1", | ||
| "esbuild-wasm": "0.23.0", | ||
| "gettext-parser": "8.0.0", | ||
| "htmlparser": "1.7.7", | ||
| "jed": "1.1.1", | ||
| "language-map": "1.5.0", | ||
| "mime-db": "1.52.0", | ||
| "sass": "1.77.6", | ||
| "sizzle": "2.3.10", | ||
| "stylelint": "16.3.1", | ||
| "stylelint-config-recommended-scss": "14.0.0", | ||
| "stylelint-config-standard": "36.0.1", | ||
| "stylelint-config-standard-scss": "13.1.0", | ||
| "stylelint-formatter-pretty": "4.0.0", | ||
| "stylelint-use-logical-spec": "^5.0.1", | ||
| "tsx": "4.16.0", | ||
| "typescript": "5.5.3" | ||
| }, | ||
| "dependencies": { | ||
| "@patternfly/patternfly": "5.3.1", | ||
| "@patternfly/react-core": "5.3.4", | ||
| "@patternfly/react-icons": "5.3.2", | ||
| "@patternfly/react-styles": "5.3.1", | ||
| "@patternfly/react-table": "5.3.4", | ||
| "@patternfly/react-tokens": "5.3.1", | ||
| "dequal": "2.0.3", | ||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1", | ||
| "throttle-debounce": "5.0.0" | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice to have, but every time dependatbot updates the biome version I feel someone needs to come and manually update this.
From the docs we can also do:
{ "$schema": "./node_modules/@biomejs/biome/configuration_schema.json" }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, not sure if we want too