Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest conditions #1305

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

jelly
Copy link
Member

@jelly jelly commented Jun 14, 2023

Check for the existence of the podman.socket for the Cockpit client scenario.

See cockpit-project/cockpit#18935

@martinpitt
Copy link
Member

this failure looks relevant. The rest look like unrelated flakes.

@jelly
Copy link
Member Author

jelly commented Jun 15, 2023

this failure looks relevant. The rest look like unrelated flakes.

Well yeah, systemctl daemon-reload needs to be run /o\

@jelly jelly force-pushed the manifest-conditionals branch from f2852b4 to e9512b1 Compare June 15, 2023 10:12
@jelly
Copy link
Member Author

jelly commented Jun 15, 2023

Rawhide fails! I wonder why hmmmmmm

Traceback (most recent call last):
  File "/var/ARTIFACTS/work-misctcad294o/plans/all/misc/discover/default-0/tests/test/check-application", line 2576, in testManifest
    self.assertIn("Podman", b.text("#host-apps .pf-m-current"))
AssertionError: 'Podman' not found in 'Overview'

# Result testManifest (__main__.TestApplication.testManifest) failed
# 1 TEST FAILED [12s on ip-172-31-23-208]
not ok 5 /var/ARTIFACTS/work-misctcad294o/plans/all/misc/discover/default-0/tests/test/check-application TestApplication.testManifest [ND@-1] # RETRY 1 (be robust against unstable tests)

@martinpitt
Copy link
Member

@jelly Because TF's rawhide image is still a bit older, the new 294 version isn't in that yet?

@jelly
Copy link
Member Author

jelly commented Jun 15, 2023

@jelly Because TF's rawhide image is still a bit older, the new 294 version isn't in that yet?

cockpit-podman-70-1.20230615102703519730.pr1305.2.ge9512b1.fc39.noarch
cockpit-bridge-294-1.fc39.x86_64

So hmm this should use the Python bridge.

@jelly jelly force-pushed the manifest-conditionals branch from e9512b1 to 9c7b6a6 Compare June 15, 2023 13:13
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it still failed on most OSes, although the logic looks okay to me 😢

test/check-application Show resolved Hide resolved
test/check-application Outdated Show resolved Hide resolved
@jelly jelly force-pushed the manifest-conditionals branch from 9c7b6a6 to d231d66 Compare June 15, 2023 14:15
Check for the existence of the podman.socket for the Cockpit client
scenario.
@jelly jelly force-pushed the manifest-conditionals branch from d231d66 to d67bf2c Compare June 15, 2023 14:24
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@martinpitt
Copy link
Member

really stubborn!

@martinpitt
Copy link
Member

This is really stubborn, I already retried like 5 times. @jelly this smells a lot like cockpit-project/bots#4829 , let's just copy the naughty?

@martinpitt
Copy link
Member

I filed cockpit-project/bots#4884 to fix this. Landing this PR as it's unrelated.

@martinpitt martinpitt merged commit 36e55a6 into cockpit-project:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants