test: reduce line length to 118 the default in Cockpit #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
force-pushed
the
reduce-line-length-final
branch
from
bac20b9 to
7385b7d
Compare
We can now start running ruff in CI.
Copy the rules which Cockpit-machines enables, except ignore FBT003 for now and PT as they require more work to fix.
jelly
force-pushed
the
reduce-line-length-final
branch
from
0e03cc5 to
024aedb
Compare
cockpituous
reviewed
Jun 22, 2023
| @@ -92,7 +92,7 @@ const ContainerEnv = ({ containerEnv, imageEnv }) => { | |||
| const ContainerIntegration = ({ container, containerDetail, localImages }) => { | |||
| if (containerDetail === null || localImages === null) { | |||
| return ( | |||
| <EmptyStatePanel title={_('Loading details...')} loading /> | |||
| <EmptyStatePanel title={_("Loading details...")} loading /> | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
|
this is stubborn. But this looks a lot like cockpit-project/bots#4829 , just that the patterns somehow don't match |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now start running ruff in CI.
As follow up:
test/static-codefrom Cockpit like machines