Validate hostPath based on the error callback from FileAutoComplete #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
reviewed
Nov 10, 2023
jelly
commented
Nov 10, 2023
src/ImageRunModal.jsx
Outdated
| @@ -659,6 +659,7 @@ export class ImageRunModal extends React.Component { | |||
| * Index needs to corellate with a row number | |||
| */ | |||
| dynamicListOnValidationChange = (value, key) => { | |||
| console.log('dynamic list validation', value, key); | |||
jelly
commented
Nov 10, 2023
src/Volume.jsx
Outdated
| @@ -38,9 +40,11 @@ export const Volume = ({ id, item, onChange, idx, removeitem, additem, options, | |||
| > | |||
| <FileAutoComplete id={id + "-host-path"} | |||
| value={item.hostPath || ''} | |||
| onChange={value => { | |||
| onChange={(value, error) => { | |||
| console.log(`value: ${value}, error: ${error}`); | |||
|
Okay, can you please clean up the debugging leftovers, and add an integration test? Thanks! |
How do we deal with the dependent Cockpit PR? Edit: Landed cockpit-project/cockpit#19600 so will do the follow up. |
jelly
force-pushed
the
volume-host-path-validation
branch
from
40d33d0 to
297b0ee
Compare
Done, but now I found another issue. When we provide a path without a trailing slash the validation doesn't work. |
jelly
force-pushed
the
volume-host-path-validation
branch
from
297b0ee to
96b1cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on this PR in Cockpit: cockpit-project/cockpit#19600
@martinpitt you looked at the validation PR before, mind giving this a look as well?