pkg: fix fragments should contain more then one child #20254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
requested changes
Apr 3, 2024
Comment on lines
258
to
260
| isInline={!!iface} | ||
| onClick={syn_click(model, show)} | ||
| variant={!iface ? "secondary" : "link"}> |
There was a problem hiding this comment.
Seems this comes up too much :) I think we should really let eslint handle this better but that requires some starter-kit / podman work first :)
Comment on lines
1595
to
1600
| close={() => this.setState({ showRestartServicesDialog: false })} | ||
| state={this.state.state} | ||
| callTracer={(state) => this.callTracer(state)} | ||
| onValueChanged={delta => this.setState(delta)} | ||
| loadUpdates={this.loadUpdates} /> |
There was a problem hiding this comment.
Same here -- either the properties should align (prefered), or it should at least have a consistent 4-space indentation).
`oxlint` a Rust implementation of `eslint` finds more issues for the `jsx-no-useless-fragment` eslint react rule. The Rust implementation is not feature complete yet so we can't yet switch over.
jelly
force-pushed
the
jsx-no-useless-fragment
branch
from
af17048 to
e75bd6f
Compare
cockpituous
reviewed
Apr 3, 2024
Comment on lines
+1464
to
+1465
| <RestartServices | ||
| tracerPackages={this.state.tracerPackages} |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oxlinta Rust implementation ofeslintfinds more issues for thejsx-no-useless-fragmenteslint react rule. The Rust implementation is not feature complete yet so we can't yet switch over.https://oxc-project.github.io/blog/2023-12-12-announcing-oxlint.html