test: Add Browser.have_test_api() #21349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is redundant state: the webdriver can already tell us whether it is still running. This flag wasn't meant to be public API, no external project uses it except cockpit-machines -- and that uses it wrongly.
Check if the browser is running and has cockpit loaded, i.e. our various ph_*() test-functions.js are actually available and thus we can call `Browser.is_visible()` and friends. That may not be the case when Cockpit hasn't been opened yet and thus the browser is still showing a blank page, or has e.g. Grafana opened. This is what `Browser.assert_no_oops()` actually needs to check, as on non-Cockpit pages this doesn't make sense. This will also help cockpit-machines to replace its incorrect usage of the just removed `Browser.valid` flag with something useful.
martinpitt
added a commit
to martinpitt/cockpit-machines
that referenced
this pull request
Nov 28, 2024
Some tests like `testAddDiskNFS` fail during setup [1], so the test teardown runs while the browser still shows a blank page. Use the new `Browser.have_test_api()` from cockpit-project/cockpit#21349 instead of merely checking if the browser is running to clean that up. [1] cockpit-project/bots#7137
2 tasks
jelly
approved these changes
Nov 29, 2024
martinpitt
added a commit
to martinpitt/cockpit-machines
that referenced
this pull request
Nov 29, 2024
Some tests like `testAddDiskNFS` fail during setup [1], so the test teardown runs while the browser still shows a blank page. Use the new `Browser.have_test_api()` from cockpit-project/cockpit#21349 instead of merely checking if the browser is running to clean that up. [1] cockpit-project/bots#7137
jelly
pushed a commit
to cockpit-project/cockpit-machines
that referenced
this pull request
Nov 29, 2024
Some tests like `testAddDiskNFS` fail during setup [1], so the test teardown runs while the browser still shows a blank page. Use the new `Browser.have_test_api()` from cockpit-project/cockpit#21349 instead of merely checking if the browser is running to clean that up. [1] cockpit-project/bots#7137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the browser is running and has cockpit loaded, i.e. our various
ph_*() test-functions.js are actually available and thus we can call
Browser.is_visible()and friends. That may not be the case whenCockpit hasn't been opened yet and thus the browser is still showing a
blank page, or has e.g. Grafana opened.
This is what
Browser.assert_no_oops()actually needs to check, as onnon-Cockpit pages this doesn't make sense.
This will also help cockpit-machines to replace its incorrect usage of
the just removed
Browser.validflag with something useful.This will help with cleaning up the very messy
testAddDiskNFSfailures here and here. I sent a corresponding cockpit-machines PR which uses this: cockpit-project/cockpit-machines#1929