Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Move away from pinned old Ubuntu 22.04 release #21496

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Jan 8, 2025

See individual commits for details. Most of these are self-validating, and I'm just taking my chance on the ws container build one. I'll run it after landing and do a follow-up in the unlikely case that it breaks.

This leaves the flatpak-test, but that does fail on Ubuntu 24.04. It's on the pilot board, I'll look at that separately.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This is easy to validate in PRs, and there is no particular reason to
pin it to a particular Ubuntu release.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The documentation [1] says that, and there is no reason to deviate from
that and pin down an old Ubuntu release. This is also easy to validate
in PRs.

[1] https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning
There is nothing complicated going on here (no containers, no large tar
piping, etc.). Our bots tend to use modern Python, so always stay on the
latest Ubuntu release instead of pinning down and old release.
This all runs in a docker container, and these are supported very well
on GitHub in all releases. So no need to pin this to a particular
Ubuntu release.
@martinpitt martinpitt added no-test For doc/workflow changes, or experiments which don't need a full CI run, .github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows labels Jan 8, 2025
@martinpitt martinpitt requested a review from mvollmer January 8, 2025 05:50
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvollmer mvollmer merged commit 809ed8a into cockpit-project:main Jan 8, 2025
32 of 34 checks passed
@martinpitt martinpitt deleted the workflows-22 branch January 8, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants