manifest related cleanups #21513
Merged
manifest related cleanups #21513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file was renamed in commit f459553.
The Python bridge has never served that. Fixes cockpit-project#20984
The Python bridge has never implemented them. These now just cause a lot of 404 error message noise when starting a Cockpit session.
jelly
reviewed
Jan 13, 2025
| @@ -8,9 +8,6 @@ | |||
| <link href="../../static/branding.css" rel="stylesheet" /> | |||
| <script src="../base1/cockpit.js"></script> | |||
| <script src="../manifests.js"></script> | |||
| <!-- HACK: C bridge loads translations via glob and Python via manifest.js --> | |||
| <script src="../*/po.manifest.js"></script> | |||
| <script src="../*/po.js"></script> | |||
There was a problem hiding this comment.
As we beiboot in cockpit client and other situations I suppose there is no way an old bridge server new shell code. So this seems fine.
There was a problem hiding this comment.
Yes, that was my thought as well. The debs and rpm ensure that cockpit-{bridge,system} have the same version, and Arch doesn't even split the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20984