test: Handle React form inputs #9394
Conversation
Setting the value plus emitting the "change" event is not enough.
Setting the checked property and emitting the "change" signal does not work with React.
mvollmer
force-pushed
the
test-react-forms
branch
from
1301bfa to
299cb12
Compare
| @@ -231,6 +231,11 @@ def key_press(self, keys): | |||
| else: | |||
| self.cdp.invoke("Input.dispatchKeyEvent", type="char", text=k) | |||
|
|
|||
| def set_input_text(self, selector, val): | |||
There was a problem hiding this comment.
I would explicitly mention "type" in the name of this function
There was a problem hiding this comment.
I'd say "typing" is an implementation detail. If we later find a better way that doesn't involve key-press events, I think we should use it.
| @@ -280,7 +280,7 @@ export const PassInput = (tag, title, options) => { | |||
| initial_value: "", | |||
|
|
|||
| render: (val, change) => | |||
| <input data-field={tag} | |||
| <input data-field={tag} data-field-type="text-input" | |||
There was a problem hiding this comment.
As mentioned in other PRs, the data-* attributes are not preferred in React. They exist just for compatibility with (older) libraries.
Wouldn't it be better to determine the type form css class? If not in all cases recently, we can add a new one, without it's definition.
There was a problem hiding this comment.
We might use a class for data-field-type, but it's more difficult for data-tag. But I don't see why we should stop using data-* attributes. They work, React doesn't warn about them, and there isn't a equivalent alternative, right?
|
Let's merge this now, as there are quite a lot of other React PRs and these tend to age quickly. It doesn't make the code any worse, and we can iterate on it again. |
No description provided.