tasks: Install dbus-daemon and valgrind, move config and secret setup to separate script #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are necessary for running cockpit's unit tests. This is useful for human developers, and also paves the way for moving the unit test CI run to the tasks container.
1 task
jelly
previously approved these changes
Feb 13, 2024
This has tripped me up time and again when `podman exec`'ing into a container, as in that shell the variable wouldn't be set. This also helps with moving the initialization to a separate script.
This paves the way for using the tasks containter in "single job" mode without the `cockpit-tasks` mainloop.
We want to run cockpit's unit tests in the tasks container. They require the current user to have an /etc/passwd entry, and the tests to not run as root. GitHub workflows run as UID 1001, so add a user for that.
|
@jelly I made a boo-boo, which caused |
jelly
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.