Skip to content

Commit

Permalink
3scale: Don't upgrade all connections
Browse files Browse the repository at this point in the history
This is conceptually broken -- the browser should decide when it wants
to upgrade a connection to websocket, and we should just pass that
through (like we do with `Upgrade:` already). This is also what the real
3scale does, so more faithfully reproduces its behaviour.

This also helps to avoid aio-libs/aiohttp#4581
  • Loading branch information
martinpitt committed Sep 19, 2022
1 parent 458305f commit 2f2362d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion 3scale/nginx.conf
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ http {
proxy_http_version 1.1;
proxy_buffering off;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "upgrade";
proxy_set_header Connection $http_connection;

# Pass ETag header from Cockpit to clients.
# See: https://github.com/cockpit-project/cockpit/issues/5239
Expand Down

0 comments on commit 2f2362d

Please sign in to comment.