Rework session container and startup scripts #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is some incompatibility with older podman, starting the container raises a 500 error. Something wrong with the |
martinpitt
force-pushed
the
session-ws
branch
from
bcc9037
to
9e04246
Compare
This gives us more control over the container and drops the outdated and PoC/hack quay.io/rhn_engineering_mpitt/ws image. Running just one image on OpenShift is also more efficient.
This is too complex as a podman startup command, and it would have to be repeated for k8s deployment. Instead, parameterize it with environment variables. Move the "socat-session.sh" helper from the image into the startup script.
…ogram This eliminates the last websocat usage, as it is not packaged anywhere, and downloading straight from GitHub isn't appropriate for production. Fixes #42
martinpitt
force-pushed
the
session-ws
branch
from
9e04246
to
4a915a7
Compare
martinpitt
commented
Sep 26, 2022
Comment on lines
+5
to
+7
| # cockpit is not available in UBI, install from CentOS 9 stream; c-bridge is just for debugging, drop for production | ||
| RUN printf '[c9s]\nname = C9S\nbaseurl = http://mirror.stream.centos.org/9-stream/BaseOS/x86_64/os\ngpgcheck = 0\n' > /etc/yum.repos.d/c9s.repo | ||
| RUN microdnf install --enablerepo=c9s --setopt=install_weak_deps=0 -y cockpit-ws cockpit-bridge && microdnf clean all |
There was a problem hiding this comment.
This is of course rather ugly -- it might not be the final solution. We could also install python3-websockets (or websocat) into our official cockpit/ws container -- but that remains to be discussed with the SREs/reviewers for official deployment.
jelly
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42