Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default numbers test #267

Merged
merged 2 commits into from
May 27, 2023

Conversation

andyyang890
Copy link
Contributor

This patch fixes the default numbers test to expect the correct result after cockroachdb/cockroach#102299 was merged.

@andyyang890 andyyang890 marked this pull request as ready for review May 23, 2023 02:58
@andyyang890 andyyang890 requested review from rafiss and a team May 23, 2023 02:58
@andyyang890 andyyang890 force-pushed the fix_default_numbers branch 2 times, most recently from 2d50520 to 127a379 Compare May 23, 2023 18:38
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

This patch fixes the default numbers test to expect the correct result
after cockroachdb/cockroach#102299 was merged.
@andyyang890 andyyang890 merged commit be2a6b3 into cockroachdb:master May 27, 2023
@andyyang890 andyyang890 deleted the fix_default_numbers branch May 27, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants