Add statements page #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhartunian
requested changes
Jul 21, 2020
dhartunian
approved these changes
Jul 28, 2020
- Add components that used in Statements page - Add Less loader to import Antd styles - Process .scss as not plain file (not module) to import `react-select` styles
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Aug 5, 2020
51910: ui: use StatementsPage from admin-ui-components r=koorosh a=koorosh Depends on cockroachdb/admin-ui-components#9 Depends on cockroachdb/yarn-vendored#27 Depends on cockroachdb/yarn-vendored#28 `StatementsPage` component is replaced with previously extracted version of StatementsPage in `admin-ui-components`. The new version (extracted) of `StatementsPage` has several changes that required to make the following adjustments: - `ActivateStatementDiagnostics` modal isn't connected components anymore so dispatching actions are pulled up to connected StatementsPage wrapper. - Previously, analytics functions (which track user interaction) were called directly from React components that made this functionality tightly coupled. Now, sagas used to watch actions related to user interaction and then call async logic in sagas. -- components expose only callback functions which are related to the the logic component is responsible; -- connected component is responsible to dispatch actions with proper payload to be properly then handled by sagas. Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason I put all changes into single PR is to add all components which needed for Statements page
and manage to display components in Storybooks.
StatementsPagecomponent is added to Storybook for visual testing;Current changes are not final. Following changes have to be made:
Note:
react-selectexternal libraryproto.jsfiles. Later, it has to be external dependency and for now,src/js/dir (from Admin UI) has to be copied with all content to./src/js.