Merge pull request #92 from cockroachdb/lint

add some linting to travis

.travis.yml

@@ -1,7 +1,14 @@
 language: go
 
 go:
-  - 1.9.x
-  - 1.10.x
+  - 1.11.x
+  - 1.12.x
 
-script: go test
+before_install:
+  - go get golang.org/x/lint/golint
+  - go get honnef.co/go/tools/cmd/staticcheck
+
+script:
+  - go test
+  - golint .
+  - staticcheck .

decimal.go

@@ -202,21 +202,6 @@ func (c *Context) SetString(d *Decimal, s string) (*Decimal, Condition, error) {
 	return d, res, err
 }
 
-func (d *Decimal) strSpecials() (bool, string) {
-	switch d.Form {
-	case NaN:
-		return true, "NaN"
-	case NaNSignaling:
-		return true, "sNaN"
-	case Infinite:
-		return true, "Infinity"
-	case Finite:
-		return false, ""
-	default:
-		return true, "unknown"
-	}
-}
-
 // Set sets d's fields to the values of x and returns d.
 func (d *Decimal) Set(x *Decimal) *Decimal {
 	if d == x {

decomposer.go

@@ -14,9 +14,7 @@
 
 package apd
 
-import (
-	"fmt"
-)
+import "fmt"
 
 // decomposer composes or decomposes a decimal value to and from individual parts.
 // There are four separate parts: a boolean negative flag, a form byte with three possible states
@@ -48,6 +46,8 @@ type decomposer interface {
 	Compose(form byte, negative bool, coefficient []byte, exponent int32) error
 }
 
+var _ decomposer = &Decimal{}
+
 // Decompose returns the internal decimal state into parts.
 // If the provided buf has sufficient capacity, buf may be returned as the coefficient with
 // the value set and length set as appropriate.