Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apd: add go 1.19 testing to CI #126

Merged

Conversation

nvanbenschoten
Copy link
Member

This commit adds a test variant for go 1.19.

@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/testGo19 branch 2 times, most recently from f568ffa to a4ea096 Compare October 31, 2022 23:25
This commit adds a test variant for go 1.19.
Copy link

@cucaroach cucaroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just curious, is there an issue that describes this staticcheck issue somewhere?

@nvanbenschoten
Copy link
Member Author

TFTR!

Just curious, is there an issue that describes this staticcheck issue somewhere?

It's not an issue per-se. Staticcheck added a new lint against the use of io/ioutil in go1.19. See dominikh/go-tools@19a6a3c.

@nvanbenschoten nvanbenschoten merged commit 3bce48c into cockroachdb:master Nov 1, 2022
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/testGo19 branch March 27, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants