apd: add decomposer interface methods #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: I think I have a crdb CLA signed, but I if it isn't on file (I think the CLA service they were using at first went down), I can sign a new one. Intent is to post the PRs as drafts on a few decimal packages, then if we can agree on the interface, commit them around the same time. The interface is designed to be self-contained, not needing to reference any outside package, but I posted a package for human reference here: https://github.com/golang-sql/decomposer . |
kardianos
force-pushed
the
kardianos-decomposer
branch
3 times, most recently
from
a4ce8be to
bfddd2b
Compare
|
@mjibson Would you be willing to consider this PR? |
maddyblue
reviewed
May 1, 2019
kardianos
force-pushed
the
kardianos-decomposer
branch
from
bfddd2b to
545b7c9
Compare
maddyblue
reviewed
May 1, 2019
This implements the interface as worked on in the issue https://golang.org/issue/30870 .
kardianos
force-pushed
the
kardianos-decomposer
branch
from
545b7c9 to
a284612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the interface as worked on in the
issue https://golang.org/issue/30870 .