This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is part of the msan-unclean chain described in
protocolbuffers/protobuf#1099.
We see this on the go1.6 branch in the main repo:
Defining LANG_CXX11 morphs this into:
But this code path is also hit by other msan-unclean chains, so we
end up with fewer blacklisted functions overall.
The
string_as_array
callsite affected by this:https://github.com/google/protobuf/blob/v3.0.0-beta-2/src/google/protobuf/io/zero_copy_stream_impl_lite.h#L359:L367