Skip to content

Commit

Permalink
sqlsmith: silence sqlsmith issue filing after query timeout
Browse files Browse the repository at this point in the history
Release note: None
  • Loading branch information
rohany committed Feb 26, 2020
1 parent ca557e0 commit 02c0cdf
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions pkg/cmd/roachtest/sqlsmith.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,15 @@ func registerSQLSmith(r *testRegistry) {
}(ctx)
select {
case <-time.After(timeout * 2):
t.Fatalf("query timed out, but did not cancel execution:\n%s;", stmt)
// SQLSmith generates queries that either perform full table scans of
// large tables or backup/restore operations that timeout. These
// should not cause an issue to be raised, as they most likely are
// just timing out.
c.l.Printf("query timed out, but did not cancel execution:\n%s;", stmt)
return nil
case err := <-done:
return err
}
panic("unreachable")
}()
if err != nil {
es := err.Error()
Expand Down

0 comments on commit 02c0cdf

Please sign in to comment.