-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
backupccl: break dependency on gossip
This commit removes the dependency of the backup / restore on gossip. Previously, gossip was used to count the number of nodes in the cluster, and this information is used for telemetry reporting as well as for chunking up the working spans. However, that seems unnecessary and in some cases incorrect. In particular, for backup telemetry we computed speed per node via dividing by the cluster node count, but we might have used less SQL instances, so we should actually be dividing by the number of SQL instances used in the backup plan. In restore we use all available SQL instances, and we now calculate that number right before using it for telemetry calculation. It's possible that we used different number of instances in the restore operations (which there appear to be three) when the instances went up or down, but it's probably not that important. Release note: None
- Loading branch information
1 parent
8814ce5
commit 0606fce
Showing
4 changed files
with
37 additions
and
68 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters