*: remove extra logging

Combine with previous commit before merging

Release note: None

pkg/cmd/roachtest/bank.go

@@ -246,9 +246,6 @@ func (s *bankState) chaosMonkey(
  return false
  }
 
- c.l.Printf("round %d: verifying accounts\n", curRound)
- s.verifyAccounts(ctx, t)
-
  // Sleep until at least one client is writing successfully.
  c.l.Printf("round %d: monkey sleeping while cluster recovers...\n", curRound)
  for !s.done(ctx) && !madeProgress() {

pkg/rpc/nodedialer/nodedialer.go

@@ -17,7 +17,6 @@ package nodedialer
 import (
  "context"
  "net"
- "runtime/debug"
  "time"
  "unsafe"
 
@@ -102,13 +101,11 @@ func (n *Dialer) Dial(ctx context.Context, nodeID roachpb.NodeID) (_ *grpc.Clien
 
  addr, err := n.resolver(nodeID)
  if err != nil {
- log.Infof(ctx, "n%d: breaker opened\n%s", nodeID, debug.Stack())
  breaker.Fail()
  return nil, err
  }
  conn, err := n.rpcContext.GRPCDial(addr.String()).Connect(ctx)
  if err != nil {
- log.Infof(ctx, "n%d: breaker opened\n%s", nodeID, debug.Stack())
  breaker.Fail()
  return nil, err
  }
@@ -153,11 +150,7 @@ func (n *Dialer) DialInternalClient(
  // ConnHealth when scheduling processors, but can then see attempts to send
  // RPCs fail when dial fails due to an open breaker. Reset the breaker here
  // as a stop-gap before the reconciliation occurs.
- breaker := n.getBreaker(nodeID)
- if !breaker.Ready() {
- log.Infof(ctx, "n%d: %s: but dialed anyways", nodeID, circuit.ErrBreakerOpen)
- }
- breaker.Reset()
+ n.getBreaker(nodeID).Reset()
  if err := grpcutil.ConnectionReady(conn); err != nil {
  return nil, nil, err
  }

pkg/sql/distsql_physical_planner.go

@@ -608,8 +608,6 @@ type distSQLNodeHealth struct {
 }
 
 func (h *distSQLNodeHealth) check(ctx context.Context, nodeID roachpb.NodeID) error {
- log.Infof(ctx, "n%d: checking node health", nodeID)
-
  {
  // NB: as of #22658, ConnHealth does not work as expected; see the
  // comment within. We still keep this code for now because in
@@ -624,18 +622,15 @@ func (h *distSQLNodeHealth) check(ctx context.Context, nodeID roachpb.NodeID) er
  // instead). Note: this can never happen for our nodeID (which
  // always has its address in the nodeMap).
  log.VEventf(ctx, 1, "marking n%d as unhealthy for this plan: %v", nodeID, err)
- log.Infof(ctx, "n%d: node health: %v", nodeID, err)
  return err
  }
- log.Infof(ctx, "n%d: node health: %v", nodeID, err)
  }
  {
  live, err := h.isLive(nodeID)
  if err == nil && !live {
  err = errors.New("node is not live")
  }
  if err != nil {
- log.Infof(ctx, "n%d: node health: %v", nodeID, err)
  return errors.Wrapf(err, "not using n%d due to liveness", nodeID)
  }
  }
@@ -649,14 +644,12 @@ func (h *distSQLNodeHealth) check(ctx context.Context, nodeID roachpb.NodeID) er
  // written on startup, the most likely scenario is
  // that the node is ready. We therefore return no
  // error.
- log.Infof(ctx, "n%d: node healthy (not draining)", nodeID)
  return nil
  }
 
  if drainingInfo.Draining {
  errMsg := fmt.Sprintf("not using n%d because it is draining", nodeID)
  log.VEvent(ctx, 1, errMsg)
- log.Infof(ctx, "n%d: node health: %s", nodeID, errMsg)
  return errors.New(errMsg)
  }