Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
85578: cast: remove unused function call r=yuzefovich a=yuzefovich

This was introduced in 7d0f75a, seems
like a leftover from debugging.

Release note: None

85628: bazel: bump size of `streamingest_test` r=jlinder a=rickystewart

This has timed out in CI.

Release note: None

85631: ccl/streamingccl/streamingest: skip TestTenantStreamingDeleteRange r=adityamaru a=stevendanna

Refs: #85630

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Co-authored-by: Steven Danna <danna@cockroachlabs.com>
  • Loading branch information
4 people committed Aug 4, 2022
4 parents 4cf3330 + 8ece3c7 + 45e175a + 3b04849 commit 2f77d8a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/ccl/streamingccl/streamingest/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ go_library(

go_test(
name = "streamingest_test",
size = "medium",
size = "large",
srcs = [
"main_test.go",
"stream_ingestion_frontier_processor_test.go",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,7 @@ func TestTenantStreamingCutoverOnSourceFailure(t *testing.T) {

func TestTenantStreamingDeleteRange(t *testing.T) {
defer leaktest.AfterTest(t)()
skip.WithIssue(t, 85630, "flaky test")
defer log.Scope(t).Close(t)

// TODO(casper): disabled due to error when setting a cluster setting
Expand Down
1 change: 0 additions & 1 deletion pkg/sql/sem/cast/cast.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ func ValidCast(src, tgt *types.T, ctx Context) bool {
func LookupCast(src, tgt *types.T) (Cast, bool) {
srcFamily := src.Family()
tgtFamily := tgt.Family()
srcFamily.Name()

// Unknown is the type given to an expression that statically evaluates
// to NULL. NULL can be immutably cast to any type in any context.
Expand Down

0 comments on commit 2f77d8a

Please sign in to comment.