Skip to content

Commit

Permalink
storage: disable crashing for single delete callbacks
Browse files Browse the repository at this point in the history
As elaborated in code comments, these can be false positives caused by
delete-only compactions. The metrics are not disabled, under the rare
chance that we see a problem in a cluster and one of the metrics (if
it happens to not be a false positive) gives us a hint about the cause
of the problem. For the same reason, we log such callbacks every 5
minutes, so we can correlate the key in such logs with an actual
problem. False positives should be rare, especially for the invariant
violation callback.

Informs #115881
Informs #114421

Epic: none

Release note (ops change): The cluster settings
storage.single_delete.crash_on_invariant_violation.enabled and
storage.single_delete.crash_on_ineffectual.enabled are disabled and
must not be enabled.
  • Loading branch information
sumeerbhola committed Dec 20, 2023
1 parent 3b9a2c7 commit 33d9a78
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 33d9a78

Please sign in to comment.