-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
36926: exec: add a few window function operators in simple cases r=yuzefovich a=yuzefovich Adds support for ROW_NUMBER, RANK, and DENSE_RANK window functions when there is a single window function in the query with no PARTITION BY clause and with no window frame. Addresses: #37035. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
- Loading branch information
Showing
7 changed files
with
317 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| // Copyright 2019 The Cockroach Authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| // implied. See the License for the specific language governing | ||
| // permissions and limitations under the License. | ||
|
|
||
| package vecbuiltins | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/cockroachdb/cockroach/pkg/sql/distsqlpb" | ||
| "github.com/cockroachdb/cockroach/pkg/sql/exec" | ||
| "github.com/cockroachdb/cockroach/pkg/sql/exec/coldata" | ||
| "github.com/cockroachdb/cockroach/pkg/sql/exec/types" | ||
| ) | ||
|
|
||
| type rankOp struct { | ||
| input exec.Operator | ||
| dense bool | ||
| // distinctCol is the output column of the chain of ordered distinct | ||
| // operators in which true will indicate that a new rank needs to be assigned | ||
| // to the corresponding tuple. | ||
| distinctCol []bool | ||
| outputColIdx int | ||
|
|
||
| // rank indicates which rank should be assigned to the next tuple. | ||
| rank int64 | ||
| // rankIncrement indicates by how much rank should be incremented when a | ||
| // tuple distinct from the previous one on the ordering columns is seen. It | ||
| // is used only in case of a regular rank function (i.e. not dense). | ||
| rankIncrement int64 | ||
| } | ||
|
|
||
| var _ exec.Operator = &rankOp{} | ||
|
|
||
| // NewRankOperator creates a new exec.Operator that computes window function | ||
| // RANK or DENSE_RANK. dense distinguishes between the two functions. input | ||
| // *must* already be ordered on orderingCols (which should not be empty). | ||
| // outputColIdx specifies in which exec.ColVec the operator should put its | ||
| // output (if there is no such column, a new column is appended). | ||
| func NewRankOperator( | ||
| input exec.Operator, | ||
| inputTyps []types.T, | ||
| dense bool, | ||
| orderingCols []distsqlpb.Ordering_Column, | ||
| outputColIdx int, | ||
| ) (exec.Operator, error) { | ||
| if len(orderingCols) == 0 { | ||
| return exec.NewConstOp(input, types.Int64, int64(1), outputColIdx) | ||
| } | ||
| distinctCols := make([]uint32, len(orderingCols)) | ||
| for i := range orderingCols { | ||
| distinctCols[i] = orderingCols[i].ColIdx | ||
| } | ||
| op, outputCol, err := exec.OrderedDistinctColsToOperators(input, distinctCols, inputTyps) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &rankOp{input: op, dense: dense, distinctCol: outputCol, outputColIdx: outputColIdx}, nil | ||
| } | ||
|
|
||
| func (r *rankOp) Init() { | ||
| r.input.Init() | ||
| // RANK and DENSE_RANK start counting from 1. Before we assign the rank to a | ||
| // tuple in the batch, we first increment r.rank, so setting this | ||
| // rankIncrement to 1 will update r.rank to 1 on the very first tuple (as | ||
| // desired). | ||
| r.rankIncrement = 1 | ||
| } | ||
|
|
||
| func (r *rankOp) Next(ctx context.Context) coldata.Batch { | ||
| b := r.input.Next(ctx) | ||
| if b.Length() == 0 { | ||
| return b | ||
| } | ||
| if r.outputColIdx == b.Width() { | ||
| b.AppendCol(types.Int64) | ||
| } else if r.outputColIdx > b.Width() { | ||
| panic("unexpected: column outputColIdx is neither present nor the next to be appended") | ||
| } | ||
| rankCol := b.ColVec(r.outputColIdx).Int64() | ||
| if r.distinctCol == nil { | ||
| panic("unexpected: distinctCol is nil in rankOp") | ||
| } | ||
| sel := b.Selection() | ||
| if sel != nil { | ||
| for i := uint16(0); i < b.Length(); i++ { | ||
| if r.distinctCol[sel[i]] { | ||
| // TODO(yuzefovich): template this part out to generate two different | ||
| // rank operators. | ||
| if r.dense { | ||
| r.rank++ | ||
| } else { | ||
| r.rank += r.rankIncrement | ||
| r.rankIncrement = 1 | ||
| } | ||
| rankCol[sel[i]] = r.rank | ||
| } else { | ||
| rankCol[sel[i]] = r.rank | ||
| if !r.dense { | ||
| r.rankIncrement++ | ||
| } | ||
| } | ||
| } | ||
| } else { | ||
| for i := uint16(0); i < b.Length(); i++ { | ||
| if r.distinctCol[i] { | ||
| // TODO(yuzefovich): template this part out to generate two different | ||
| // rank operators. | ||
| if r.dense { | ||
| r.rank++ | ||
| } else { | ||
| r.rank += r.rankIncrement | ||
| r.rankIncrement = 1 | ||
| } | ||
| rankCol[i] = r.rank | ||
| } else { | ||
| rankCol[i] = r.rank | ||
| if !r.dense { | ||
| r.rankIncrement++ | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return b | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // Copyright 2019 The Cockroach Authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| // implied. See the License for the specific language governing | ||
| // permissions and limitations under the License. | ||
|
|
||
| package vecbuiltins | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/cockroachdb/cockroach/pkg/sql/exec" | ||
| "github.com/cockroachdb/cockroach/pkg/sql/exec/coldata" | ||
| "github.com/cockroachdb/cockroach/pkg/sql/exec/types" | ||
| ) | ||
|
|
||
| type rowNumberOp struct { | ||
| input exec.Operator | ||
| outputColIdx int | ||
|
|
||
| rowNumber int64 | ||
| } | ||
|
|
||
| var _ exec.Operator = &rowNumberOp{} | ||
|
|
||
| // NewRowNumberOperator creates a new exec.Operator that computes window | ||
| // function ROW_NUMBER. outputColIdx specifies in which exec.ColVec the | ||
| // operator should put its output (if there is no such column, a new column is | ||
| // appended). | ||
| func NewRowNumberOperator(input exec.Operator, outputColIdx int) exec.Operator { | ||
| return &rowNumberOp{input: input, outputColIdx: outputColIdx} | ||
| } | ||
|
|
||
| func (r *rowNumberOp) Init() { | ||
| r.input.Init() | ||
| // ROW_NUMBER starts counting from 1. | ||
| r.rowNumber = 1 | ||
| } | ||
|
|
||
| func (r *rowNumberOp) Next(ctx context.Context) coldata.Batch { | ||
| b := r.input.Next(ctx) | ||
| if b.Length() == 0 { | ||
| return b | ||
| } | ||
| if r.outputColIdx == b.Width() { | ||
| b.AppendCol(types.Int64) | ||
| } else if r.outputColIdx > b.Width() { | ||
| panic("unexpected: column outputColIdx is neither present nor the next to be appended") | ||
| } | ||
| rowNumberCol := b.ColVec(r.outputColIdx).Int64() | ||
| sel := b.Selection() | ||
| if sel != nil { | ||
| for i := uint16(0); i < b.Length(); i++ { | ||
| rowNumberCol[sel[i]] = r.rowNumber | ||
| r.rowNumber++ | ||
| } | ||
| } else { | ||
| for i := uint16(0); i < b.Length(); i++ { | ||
| rowNumberCol[i] = r.rowNumber | ||
| r.rowNumber++ | ||
| } | ||
| } | ||
| return b | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # LogicTest: local-vec | ||
|
|
||
| statement ok | ||
| CREATE TABLE t (a INT, b STRING, PRIMARY KEY (b,a)) | ||
|
|
||
| statement ok | ||
| INSERT INTO t VALUES | ||
| (0, 'a'), | ||
| (1, 'a'), | ||
| (0, 'b'), | ||
| (1, 'b') | ||
|
|
||
| # We sort the output on all queries to get deterministic results. | ||
| query ITI | ||
| SELECT a, b, row_number() OVER () FROM t ORDER BY b, a | ||
| ---- | ||
| 0 a 1 | ||
| 1 a 2 | ||
| 0 b 3 | ||
| 1 b 4 | ||
|
|
||
| query ITI | ||
| SELECT a, b, row_number() OVER (ORDER BY a, b) FROM t ORDER BY b, a | ||
| ---- | ||
| 0 a 1 | ||
| 1 a 3 | ||
| 0 b 2 | ||
| 1 b 4 | ||
|
|
||
| query ITI | ||
| SELECT a, b, rank() OVER () FROM t ORDER BY b, a | ||
| ---- | ||
| 0 a 1 | ||
| 1 a 1 | ||
| 0 b 1 | ||
| 1 b 1 | ||
|
|
||
| query ITI | ||
| SELECT a, b, rank() OVER (ORDER BY a) FROM t ORDER BY b, a | ||
| ---- | ||
| 0 a 1 | ||
| 1 a 3 | ||
| 0 b 1 | ||
| 1 b 3 | ||
|
|
||
| query ITI | ||
| SELECT a, b, dense_rank() OVER () FROM t ORDER BY b, a | ||
| ---- | ||
| 0 a 1 | ||
| 1 a 1 | ||
| 0 b 1 | ||
| 1 b 1 | ||
|
|
||
| query ITI | ||
| SELECT a, b, dense_rank() OVER (ORDER BY a) FROM t ORDER BY b, a | ||
| ---- | ||
| 0 a 1 | ||
| 1 a 2 | ||
| 0 b 1 | ||
| 1 b 2 |