Skip to content

Commit

Permalink
bincheck: bind 127.0.0.1
Browse files Browse the repository at this point in the history
Previously, bincheck started a single node database instance without
specifying the address/port it listens on. In this case the server code
tried to resolve the hostname and use it. See
https://github.com/cockroachdb/cockroach/blob/d498a59cc2afc9778af6f7e0120206ab1ee56bc2/pkg/base/addr_validation.go#L128
for the details.

At some point this method stopped working on MacOS GitHub workers. There
is an upstream issue open: actions/runner-images#8649

This PR explicitly sets the `--listen-addr` parameter to skip the
problematic code.

Epic: none
Release note: None
  • Loading branch information
rail authored and rickystewart committed Nov 27, 2023
1 parent b69be53 commit 4d2e919
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/release/bincheck/bincheck
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ echo "Generating encryption key:"
echo ""

# Start node with encryption enabled.
"$cockroach" start-single-node --insecure --listening-url-file="$urlfile" --enterprise-encryption=path=cockroach-data,key=aes-128.key,old-key=plain --pid-file="$pidfile" &
"$cockroach" start-single-node --listen-addr 127.0.0.1:26257 --insecure --listening-url-file="$urlfile" --enterprise-encryption=path=cockroach-data,key=aes-128.key,old-key=plain --pid-file="$pidfile" &

trap "kill -9 $! || true" EXIT
for i in {0..8}
Expand Down

0 comments on commit 4d2e919

Please sign in to comment.