Skip to content

Commit

Permalink
sql: re-enable splits in tests
Browse files Browse the repository at this point in the history
Before:
```
make test PKG=./sql
go test -v  -i ./sql
go test  -run "." -timeout 1m10s ./sql
ok  	github.com/cockroachdb/cockroach/sql	24.985s
```
After:
```
make test PKG=./sql
go test -v  -i ./sql
go test  -run "." -timeout 1m10s ./sql
ok  	github.com/cockroachdb/cockroach/sql	30.452s
```

Closes #2504.
  • Loading branch information
tamird committed Jul 1, 2016
1 parent 6de8c35 commit 719ea9d
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 13 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ STATIC :=
PKG := ./...
TAGS :=
TESTS := .
TESTTIMEOUT := 1m10s
TESTTIMEOUT := 2m
RACETIMEOUT := 5m
BENCHTIMEOUT := 5m
TESTFLAGS :=
Expand Down
3 changes: 0 additions & 3 deletions sql/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@ func waitForConfigChange(t *testing.T, s *testServer) config.SystemConfig {
// TestGetZoneConfig exercises config.GetZoneConfig and the sql hook for it.
func TestGetZoneConfig(t *testing.T) {
defer leaktest.AfterTest(t)()
// Disable splitting. We're using bad attributes in zone configs
// to be able to match.
defer config.TestingDisableTableSplits()()
s, sqlDB, _ := setup(t)
defer cleanup(s, sqlDB)

Expand Down
5 changes: 0 additions & 5 deletions sql/logic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import (
"time"
"unicode/utf8"

"github.com/cockroachdb/cockroach/config"
"github.com/cockroachdb/cockroach/security"
"github.com/cockroachdb/cockroach/server"
"github.com/cockroachdb/cockroach/sql"
Expand Down Expand Up @@ -1045,10 +1044,6 @@ func (t *logicTest) traceStop() {
func TestLogic(t *testing.T) {
defer leaktest.AfterTest(t)()

// TODO(marc): splitting ranges at table boundaries causes
// a blocked task and won't drain. Investigate and fix.
defer config.TestingDisableTableSplits()()

var globs []string
if *bigtest {
const logicTestPath = "../../sqllogictest"
Expand Down
1 change: 0 additions & 1 deletion sql/rename_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import (
// a rename operation.
func TestRenameTable(t *testing.T) {
defer leaktest.AfterTest(t)()
defer config.TestingDisableTableSplits()()
_, sqlDB, kvDB, cleanup := sqlutils.SetupServer(t)
defer cleanup()

Expand Down
3 changes: 0 additions & 3 deletions sql/trace_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"testing"
"text/tabwriter"

"github.com/cockroachdb/cockroach/config"
"github.com/cockroachdb/cockroach/util/leaktest"
)

Expand Down Expand Up @@ -83,8 +82,6 @@ func prettyPrint(m [][]string) string {

func TestExplainTrace(t *testing.T) {
defer leaktest.AfterTest(t)()
defer config.TestingDisableTableSplits()()

s, sqlDB, _ := setup(t)
defer cleanup(s, sqlDB)

Expand Down

0 comments on commit 719ea9d

Please sign in to comment.