Skip to content

Commit

Permalink
colexecbase: move a single struct to clean up dependencies
Browse files Browse the repository at this point in the history
This commit moves `colexecbase.BinaryOverloadHelper` into `colexecutils`
package in order to break the dependencies of `colexecproj` and
`colexecprojconst` packages on `colexecbase`. This will speed up the
build a bit.

Release note: None
  • Loading branch information
yuzefovich committed Apr 8, 2022
1 parent 060fe6a commit 8fdd210
Show file tree
Hide file tree
Showing 13 changed files with 199 additions and 205 deletions.
1 change: 0 additions & 1 deletion pkg/sql/colexec/colexecbase/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ go_library(
"distinct.go",
"fn_op.go",
"ordinality.go",
"overloads_bin_util.go",
"simple_project.go",
":gen-exec", # keep
],
Expand Down
2 changes: 1 addition & 1 deletion pkg/sql/colexec/colexecproj/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ go_library(
"//pkg/col/typeconv", # keep
"//pkg/server/telemetry", # keep
"//pkg/sql/colconv", # keep
"//pkg/sql/colexec/colexecbase", # keep
"//pkg/sql/colexec/colexeccmp", # keep
"//pkg/sql/colexec/colexecutils", # keep
"//pkg/sql/colexec/execgen", # keep
Expand Down Expand Up @@ -97,6 +96,7 @@ disallowed_imports_test(
[
"//pkg/sql/colexec",
"//pkg/sql/colexec/colexecagg",
"//pkg/sql/colexec/colexecbase",
"//pkg/sql/colexec/colexechash",
"//pkg/sql/colexec/colexecjoin",
"//pkg/sql/colexec/colexecprojconst",
Expand Down
Loading

0 comments on commit 8fdd210

Please sign in to comment.