Skip to content

Commit

Permalink
Merge #30563
Browse files Browse the repository at this point in the history
30563: sql: remove an UnexpectedWithIssueErrorf r=andreimatei a=andreimatei

Since the respective issue has been closed.
Touches #12876

Release note: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
  • Loading branch information
craig[bot] and andreimatei committed Sep 25, 2018
2 parents 22131af + 9dcae4a commit b2bd8e8
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions pkg/sql/distsql_physical_planner.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import (
"sort"
"strings"

"github.com/pkg/errors"

"github.com/cockroachdb/cockroach/pkg/gossip"
"github.com/cockroachdb/cockroach/pkg/internal/client"
"github.com/cockroachdb/cockroach/pkg/keys"
Expand All @@ -39,11 +41,9 @@ import (
"github.com/cockroachdb/cockroach/pkg/util"
"github.com/cockroachdb/cockroach/pkg/util/encoding"
"github.com/cockroachdb/cockroach/pkg/util/envutil"
"github.com/cockroachdb/cockroach/pkg/util/errorutil"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/stop"
"github.com/cockroachdb/cockroach/pkg/util/uuid"
"github.com/pkg/errors"
)

// DistSQLPlanner is used to generate distributed plans from logical
Expand Down Expand Up @@ -517,8 +517,7 @@ func (p *PlanningCtx) sanityCheckAddresses() error {
inverted := make(map[string]roachpb.NodeID)
for nodeID, addr := range p.NodeAddresses {
if otherNodeID, ok := inverted[addr]; ok {
return errorutil.UnexpectedWithIssueErrorf(
12876,
return errors.Errorf(
"different nodes %d and %d with the same address '%s'", nodeID, otherNodeID, addr)
}
inverted[addr] = nodeID
Expand Down

0 comments on commit b2bd8e8

Please sign in to comment.