Merge #60704

60704: timeutil: sort timezones r=otan a=mneverov

Previously, timezones in the generated file were not sorted. That led to
the file being changed greatly when Go version was updated, or even
within the same Go version when /usr/local/go/lib/time/zoneinfo.zip was
regenerated from different time zone releases:
https://data.iana.org/time-zones/releases
This patch sorts timezones before writing them down so the changes in
the file are minimal and only reflect the actual change in the
timezones.

Release note: None

Co-authored-by: Max Neverov <neverov.max@gmail.com>

pkg/util/timeutil/generate_lowercase_timezones.go

@@ -25,6 +25,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"runtime"
+	"sort"
 	"strings"
 
 	"github.com/cockroachdb/errors"
@@ -70,6 +71,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("error parsing tzdata: %+v", err)
 	}
+	sort.Strings(zones)
 
 	of, err := os.Create(fileName)
 	if err != nil {