Skip to content

Commit

Permalink
c-deps: bump rocksdb for unique cache IDs on Windows
Browse files Browse the repository at this point in the history
Picks up cockroachdb/rocksdb#58.

We found a corruption caused by multiple FAT32 files assigned the same
block cache key prefix. We don't know the extent to which this problem
affects other filesystems or other Windows file ID generation mechanisms.
We decided to turn off the reliance on filesystem for generating cache
keys on Windows. Instead we use randomization per table reader. This
would cause a performance penalty for use cases that open multiple table
readers per file, but I believe cockroach is not such a use case.

Fixes #40918, fixes #40950.

Release justification: Prevents corruption on some Windows filesystems

Release note: None
  • Loading branch information
ajkr committed Sep 24, 2019
1 parent 9422434 commit ece7b8b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion c-deps/rocksdb
Submodule rocksdb updated 1 files
+11 −54 port/win/io_win.cc

0 comments on commit ece7b8b

Please sign in to comment.