Merge #97601

97601: cloudcheck: don't reuse slice r=msbutler a=dt Release note: none. Epic: none. Co-authored-by: David Taylor <tinystatemachine@gmail.com>
cockroachdb · Feb 24, 2023 · f3796ef · f3796ef
2 parents 0d3393b + dfe830c
commit f3796ef
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/cloud/cloudcheck/cloudcheck_stmt.go b/pkg/cloud/cloudcheck/cloudcheck_stmt.go
@@ -82,7 +82,8 @@ func ShowCloudStorageTestPlanHook(
 		}
 		rowResultWriter := sql.NewCallbackResultWriter(func(ctx context.Context, row tree.Datums) error {
 			// collapse the two pairs of bytes+time to a single string rate each.
-			res := row[:len(row)-2] //
+			res := make(tree.Datums, len(row)-2)
+			copy(res[:4], row[:4])
 			res[4] = tree.NewDString(rateFromDatums(row[4], row[5]))
 			res[5] = tree.NewDString(rateFromDatums(row[6], row[7]))
 			res[6] = row[8]