Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: expose isolation level through kv.Txn API #100130

Closed
nvanbenschoten opened this issue Mar 30, 2023 · 0 comments · Fixed by #100900
Closed

kv: expose isolation level through kv.Txn API #100130

nvanbenschoten opened this issue Mar 30, 2023 · 0 comments · Fixed by #100900
Assignees
@nvanbenschoten
Labels
A-kv-client Relating to the KV client and the KV interface. A-read-committed Related to the introduction of Read Committed C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@nvanbenschoten
Copy link
Member

nvanbenschoten commented Mar 30, 2023 •
edited by exalate-issue-sync bot
Loading

With the (re-)introduction of weak isolation levels, KV will want to expose isolation levels through kv.Txn API.

Jira issue: CRDB-26572

Epic CRDB-26539
@nvanbenschoten nvanbenschoten added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-client Relating to the KV client and the KV interface. T-kv KV Team A-read-committed Related to the introduction of Read Committed labels Mar 30, 2023
@nvanbenschoten nvanbenschoten self-assigned this Mar 30, 2023
@nvanbenschoten nvanbenschoten mentioned this issue Apr 7, 2023
Merged
nvanbenschoten added a commit to nvanbenschoten/cockroach that referenced this issue Apr 7, 2023
@nvanbenschoten
kv: expose isolation level through kv.Txn API
d6a530e 
Fixes cockroachdb#100130.

This commit exposes isolation levels through the kv.Txn API with the
introduction of a new `SetIsoLevel` method. This method behaves
similarly to `SetUserPriority`. Notably, the isolation must be set
before any operations are performed on the transaction.

Release note: None
craig bot pushed a commit that referenced this issue Apr 7, 2023
@nvanbenschoten
Merge #100900
6bf00e2 
100900: kv: expose isolation level through kv.Txn API r=nvanbenschoten a=nvanbenschoten

Fixes #100130.

This commit exposes isolation levels through the kv.Txn API with the introduction of a new `SetIsoLevel` method. This method behaves similarly to `SetUserPriority`. Notably, the isolation must be set before any operations are performed on the transaction.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig craig bot closed this as completed in 2e83183 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
A-kv-client Relating to the KV client and the KV interface. A-read-committed Related to the introduction of Read Committed C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kv: expose isolation level through kv.Txn API nvanbenschoten/cockroach
1 participant
@nvanbenschoten